Update dependencies: PyJWT and django-graphql-jwt#121
Open
lucmult wants to merge 2 commits intoPedroBern:masterfrom
Open
Update dependencies: PyJWT and django-graphql-jwt#121lucmult wants to merge 2 commits intoPedroBern:masterfrom
lucmult wants to merge 2 commits intoPedroBern:masterfrom
Conversation
Author
|
This should fix #111 |
|
This is great. |
|
@PedroBern can you merge this PR? |
Collaborator
|
Did you actually get it to install? I cloned it with your modifications and did: result: |
|
Please, can we get this trivial PR merged? 🙏 |
Collaborator
@PabloCastellano I think it is not that trivial, see my comment above. These dependencies exist for a reason. |
|
@pors That error is not related to this PR. If you clone master and do the same, you'll get incompatibilities too: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently other JWT libraries that used with django-graphql require PyJWT > 2.0, e.g: django-graphql-jwt
Remove PyJWT from the dependencies from django-graphsql-auth is safe because this isn't imported directly here.
Upgraded django-graphql-jwt from 0.3.0 to 0.3.2.
I've run the following tests locally:
$ make test ... py38-django30: commands succeeded congratulations :)Lint and format run locally too.