-
Notifications
You must be signed in to change notification settings - Fork 9
Use existing secrets for peerdb and peerdbUI password as well as nextauth. #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rets for peerdb.credentials.password, peerdbUI.credentials.password and peerdbUI.credentials.nexauth
iamKunalGupta
requested changes
Aug 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR!
A few suggestions to make things simpler and uniform
Thanks! Your changes have been merged in. Definitely much simpler! |
iamKunalGupta
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
#31
#23
Each change has been validated using helm template --debug. Additionally the ReadMe has been updated accordingly.
This PR updates the chart to allow the use of existing secrets for the following areas:
peerdb Password
peerdbUI Password
peerdbUI nextauth key
This allows you to remove any sensitive passwords \ keys from the values file. Replacing them with k8s secret(s) which can be created manually or via some other charting method or template addition.
Checklist:
peerdb
andpeerdb-catalog
charts to the same versionpeerdb-catalog/values.yaml
:temporal.admintools.image.tag
pointing to version with correct value from the dependency inpeerdb/Chart.yaml
subdependency