Skip to content

Spew full structure for all flow_errors #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Spew full structure for all flow_errors #3607

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39c40e5
Classify mongo conn pool error, spew full structure for all errors
ilidemi Oct 15, 2025
a13c5f6
no mongo, just spew
ilidemi Oct 15, 2025
68dca58
mod tidy
ilidemi Oct 16, 2025
e2daa5e
remove type, it's useless
ilidemi Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion flow/alerting/alerting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ import (
"io"
"log/slog"
"net"
"reflect"
"slices"
"strings"
"time"

"github.com/ClickHouse/clickhouse-go/v2"
"github.com/davecgh/go-spew/spew"
"github.com/go-mysql-org/go-mysql/mysql"
"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgconn"
Expand Down Expand Up @@ -445,6 +447,11 @@ const (
flowErrorTypeError flowErrorType = "error"
)

var errSpew = spew.ConfigState{
Indent: " ",
DisableMethods: true, // Don't call Error() method, show the actual fields
}

// logFlowErrorInternal pushes the error to the errors table and emits a metric as well as a telemetry message
func (a *Alerter) logFlowErrorInternal(
ctx context.Context,
Expand All @@ -456,7 +463,10 @@ func (a *Alerter) logFlowErrorInternal(
logger := internal.LoggerFromCtx(ctx)
inErrWithStack := fmt.Sprintf("%+v", inErr)
errError := inErr.Error()
loggerFunc(errError, slog.String("stack", inErrWithStack))
loggerFunc(errError,
slog.String("stack", inErrWithStack),
slog.String("type", reflect.TypeOf(inErr).String()),
slog.String("spew", errSpew.Sdump(inErr)))
Comment on lines 465 to 467
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍

if _, err := a.CatalogPool.Exec(
ctx, "INSERT INTO peerdb_stats.flow_errors(flow_name,error_message,error_type) VALUES($1,$2,$3)",
flowName, inErrWithStack, errorType.String(),
Expand Down
Loading