Add the clang-tidy is a clang-based C++ “linter” tool.#295
Open
zusage wants to merge 2 commits intoPelagicore:masterfrom
Open
Add the clang-tidy is a clang-based C++ “linter” tool.#295zusage wants to merge 2 commits intoPelagicore:masterfrom
zusage wants to merge 2 commits intoPelagicore:masterfrom
Conversation
zusage
force-pushed
the
clang-tidy
branch
3 times, most recently
from
545a98c to
2f55ea3
Compare
bitmouse
requested changes
Sep 16, 2020
Collaborator
bitmouse
left a comment
bitmouse
left a comment
There was a problem hiding this comment.
Some tweaking is required, e.g.
src/common/FaceliftUtils.h:67:5: warning: overloading 'operator()' is disallowed [fuchsia-overloaded-operator]
It is 100% valid for us. We are not fuchsia project and we do not follow their standard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.