Pinned the goreleaser version to 2#1991
Merged
jhiemstrawisc merged 3 commits intoPelicanPlatform:mainfrom Feb 10, 2025
Merged
Conversation
turetske
added
infrastructure
turetske
force-pushed
the
clearup-deprecated-goreleaser-warnings
branch
from
2a66619 to
8238134
Compare
jhiemstrawisc
requested changes
Feb 7, 2025
Member
jhiemstrawisc
left a comment
jhiemstrawisc
left a comment
There was a problem hiding this comment.
This gets rid of the goreleaser warning about using "version 0", but I don't see that it fixed the first item listed in the linked issue. When I try to build Pelican with these changes I still see:
• DEPRECATED: snapshot.name_template should not be used anymore, check https://goreleaser.com/deprecations#snapshotname_template for more info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very simple PR, fixes in the containers as well since they build from source.