Fix http.Transport copy-by-value causing race conditions#2999
Merged
turetske merged 2 commits intoPelicanPlatform:mainfrom Jan 16, 2026
Merged
Fix http.Transport copy-by-value causing race conditions#2999turetske merged 2 commits intoPelicanPlatform:mainfrom
turetske merged 2 commits intoPelicanPlatform:mainfrom
Conversation
Replace Transport dereference pattern with Clone() to prevent concurrent map write panics. When http.Transport is copied by value (by dereferencing a pointer), it creates separate mutex copies that no longer protect the shared internal map, leading to race conditions. Fixed instances: - oa4mp/proxy.go: Use Clone() instead of dereferencing *GetTransport() when customizing DialContext for Unix socket communication - web_ui/engine_test.go: Use Clone() for test transport customization Also added `go vet` to the .pre-commit checker
turetske
added
bug
h2zh
requested changes
Jan 16, 2026
Contributor
h2zh
left a comment
h2zh
left a comment
There was a problem hiding this comment.
Good catch for the transport object race condition. I also do a gerp for *config.GetTransport() to double check all occurrences are replaced. I got a concern that the newly added go-vet linter might be a duplication.
h2zh
approved these changes
Jan 16, 2026
Contributor
|
Sorry I didn't refresh the page (to get the new commit) before re-assigning this to you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Transport dereference pattern with Clone() to prevent concurrent map write panics. When http.Transport is copied by value (by dereferencing a pointer), it creates separate mutex copies that no longer protect the shared internal map, leading to race conditions.
Fixed instances:
Also added
go vetto the .pre-commit checker