Add rate limiter & metrics to the POSIXv2 implementation#3054
Merged
bbockelm merged 11 commits intoPelicanPlatform:mainfrom Feb 9, 2026
Merged
Add rate limiter & metrics to the POSIXv2 implementation#3054bbockelm merged 11 commits intoPelicanPlatform:mainfrom
bbockelm merged 11 commits intoPelicanPlatform:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bbockelm
force-pushed
the
rate_limiter
branch
from
edb51a9 to
025fc8f
Compare
bbockelm
added
enhancement
Collaborator
Author
|
@patrickbrophy - can you take a look at the Prometheus changes here? It's the first stab at making POSIXv2 & XRootD monitoring compatible (the f-stream portion is not done but will need to go in a separate PR just to break things up a bit). I'm happy with the HTB / fair-share stuff. |
patrickbrophy
requested changes
Feb 6, 2026
Contributor
patrickbrophy
left a comment
patrickbrophy
left a comment
There was a problem hiding this comment.
Just some small nits. I was ultimately concerned with the compatibility with existing metrics.
Key observation - the waiters need to generate their own ticks to refill the bucket since there is no background goroutine doing that.
- Remove unused HTTP & POSIXv2 metrics - Improve tests to actually demonstrate fair-share is working - Add Force method to HTB since tokens must be acquired while reads are ongoing
Additionally, fix the bytes read metric to not depend on the HTTP headers but the actual bytes read.
bbockelm
force-pushed
the
rate_limiter
branch
2 times, most recently
from
a29fae1 to
bcd8e93
Compare
bbockelm
force-pushed
the
rate_limiter
branch
from
bcd8e93 to
f0a48f1
Compare
patrickbrophy
approved these changes
Feb 9, 2026
Contributor
patrickbrophy
left a comment
patrickbrophy
left a comment
There was a problem hiding this comment.
Things look good on the metrics front.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.