CMake and RPM changes to get EL8 builds working#142
Merged
matyasselmeci merged 3 commits intoPelicanPlatform:mainfrom Feb 20, 2026
Merged
CMake and RPM changes to get EL8 builds working#142matyasselmeci merged 3 commits intoPelicanPlatform:mainfrom
matyasselmeci merged 3 commits intoPelicanPlatform:mainfrom
Conversation
tinyxml2 6.0.0 (EL8) provides the 'tinyxml2' target instead of the 'tinyxml2::tinyxml2' target. If the former is found, define the latter. Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Use the standard cmake macros for consistency and making sure they all find the right directories.
…nd XrdOssPoscObj This library needs to be explicitly listed on EL8 (GCC 8.5) to avoid undefined reference errors to things like `std::filesystem::__cxx11::path::_M_split_cmpts()`
patrickbrophy
approved these changes
Feb 20, 2026
Contributor
patrickbrophy
left a comment
patrickbrophy
left a comment
There was a problem hiding this comment.
I was able to build this in an EL8 container and the changes looks good. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140.
The following differences were the cause of the EL8 build failures:
tinyxml2instead oftinyxml2::tinyxml2like later versions; fixed by defining the latter if the former is foundstd::namespacedependency needed on GCC 8.5cmake --buildcommand in the spec file was assuming an out-of-source build and hardcoded the build path, but EL8 builds are in-source by default. Doubly fixed by changing the EL8 build to be out-of-source as well, and by using the standard%cmake_buildmacro to specify the same paths as the other%cmake_*macros.Tested on EL8, EL9, and EL10 builds on OSG Koji.