Fix deadlocks and crashes#87
Merged
bbockelm merged 3 commits intoPelicanPlatform:mainfrom Feb 1, 2025
Merged
Conversation
When XRootD closes the file while the cache was doing readahead, all the callback objects were deleted -- causing a segfault when the readahead finished. This adds a check during the cache destructor to ensure there are no pending operations.
The mutex protecting the state variables of the cache was held when the read request was submitted to the queue. This worked well when the queue was not at capacity -- but failed when the submission to the queue blocked. This is because the mutex is needed by the callback function to finish operations. The fix was to drop the mutex while we're entering the queue and to acquire it again afterward.
Collaborator
Author
|
Ok, after this work I'm unable to trigger any crashes in the code -- going to cut a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues found so far while stress testing:
I can no longer get the plugin to crash under Pelican downloads of the test data. However, it still periodically "stalls out" -- not returning any data from AWS -- so there's still something to hunt down.