Closed
Conversation
bbockelm
requested changes
Mar 16, 2025
Collaborator
bbockelm
left a comment
bbockelm
left a comment
There was a problem hiding this comment.
It's not clear why some of these cast to int while others to unsigned int. I think it'd be better to use mode_t -- the defined type of st_mode -- where possible.
Before we merge, can you please rebase and squash as well?
| ASSERT_EQ(fs.Stat("/test", &buf, 0, nullptr), 0); | ||
|
|
||
| ASSERT_EQ(buf.st_mode & S_IFDIR, S_IFDIR); | ||
| ASSERT_EQ(static_cast<int>(buf.st_mode & S_IFDIR), S_IFDIR); |
Collaborator
There was a problem hiding this comment.
If we need to cast, I think it'd be better to keep everything as mode_t as in:
Suggested change
| ASSERT_EQ(static_cast<int>(buf.st_mode & S_IFDIR), S_IFDIR); | |
| ASSERT_EQ(buf.st_mode & S_IFDIR, static_cast<mode_t>(S_IFDIR)); |
However, I haven't noticed this comparison issue. What platform are you hitting this on?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repairs a signing issue in some tests.