Download mc/minio executables if necessary#93
Merged
bbockelm merged 4 commits intoPelicanPlatform:mainfrom Mar 21, 2025
Merged
Conversation
bbockelm
requested changes
Mar 16, 2025
Collaborator
bbockelm
left a comment
There was a problem hiding this comment.
Existing code looks good.
However, in distro build environments (e.g., RPMs for EPEL), there's no available network connectivity and this would now cause their builds to fail.
I see two options:
- Do not make
MINIO_BINandMC_BINrequired and allow the unit tests to fail. Downstream packagers will have to hand-label tests to skip. - Add explicit CMake logic that skips tests or activities (such as
mcdownload) that require network connectivity.
Collaborator
Author
|
Thanks @bbockelm! I'm confused about the network situation, can you help me understand? Are you saying the build should succeed without minio/mc (in the absence of network) because they're not a compilation dependency, even if the runtime will fail? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A todo list:
Test cases I've run:
minio/mcand downloading if they don't existminio/mcalready existminio/mcdon't exist