Skip s3 tests in the absence of minio/mc#95
Merged
bbockelm merged 1 commit intoPelicanPlatform:mainfrom Aug 23, 2025
Merged
Conversation
Collaborator
|
I'm not sure I love this idea. Is there a reason why skipping tests is preferred to installing minio? |
bbockelm
approved these changes
Aug 23, 2025
Collaborator
bbockelm
left a comment
bbockelm
left a comment
There was a problem hiding this comment.
LGTM.
To answer @rw2's question: when on an airplane -- or if building & testing from various distro's build machines -- network connectivity may not be available to download. The Fedora folks, for example, forbid outgoing network connectivity to improve the reproducibility of their binaries.
For normal "day-to-day" development, it's preferred to have all the test run; but hopefully, in that case, the download will complete successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, don't
FATAL_ERRORFollow-up to #61 (comment)
cc @bbockelm @rw2