Open
Conversation
trowbridgec
reviewed
Jun 11, 2020
| "lwip.ethernet-enabled" : false, | ||
| "lwip.mem-size" : 22000, | ||
| "nsapi.dns-response-wait-time" : 30000, | ||
| "nsapi.default-cellular-apn" : "\"phone\"", |
There was a problem hiding this comment.
I'd remove this line since it's up to the user to specify the APN for their SIM card. It'd probably be good to put some dummy cell credentials in the * target override section above like was done here for the mbed-os-example-pelion application.
|
Hi, Regards, |
Author
|
Hi Yogesh, Our target is already enabled for that example. As an Mbed partner, we would like to see our target also enabled for this example, which we think is easier to move to production than the other Pelion client example. @maclobdell please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[X] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[X] I confirm the moderators may change the PR before merging it in.
[X] I understand the release model prohibits detailed Git history and my contribution will be recorded to the list at the bottom of CONTRIBUTING.md.
Summary of changes
Add configuration and bootloader to build example for EP_AGORA target
@maclobdell @trowbridgec