Skip to content

Replace MCFLIRT-based HMC workflow with ANTs-based one#506

Closed
tsalo wants to merge 36 commits intoPennLINC:mainfrom
tsalo:ge-disable-hmc
Closed

Replace MCFLIRT-based HMC workflow with ANTs-based one#506
tsalo wants to merge 36 commits intoPennLINC:mainfrom
tsalo:ge-disable-hmc

Conversation

@tsalo
Copy link
Copy Markdown
Member

@tsalo tsalo commented Apr 24, 2025

Closes none, but addresses a bug I found. It looks like GE processing was still running HMC.

One remaining problem is that there's no transform from the ASL file to the aslref image.

Changes proposed in this pull request

  • Create a step that mocks up fake HMC-related outputs when GE processing is enabled instead of running HMC.

@tsalo tsalo added the bug Something isn't working label Apr 24, 2025
Comment on lines +182 to +183
(reference_buffer, register_reference, [('aslref', 'fixed_image')]),
(inputnode, register_reference, [('raw_ref_image', 'moving_image')]),
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the opposite of what I would expect, but having it swapped produced bad results.

@tsalo tsalo changed the title Disable HMC when GE processing is enabled Replace MCFLIRT-based HMC workflow with ANTs-based one May 6, 2025
@tsalo
Copy link
Copy Markdown
Member Author

tsalo commented May 12, 2025

I'm currently having trouble making the right associated files (motion parameters file, RMSD file) from the ITK transforms.

@tsalo
Copy link
Copy Markdown
Member Author

tsalo commented May 23, 2025

Closing for now. If mutual information doesn't work, and volume type-specific reference images also doesn't work, then we can revisit this idea (or try NiFreeze).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant