Replace MCFLIRT-based HMC workflow with ANTs-based one#506
Closed
tsalo wants to merge 36 commits intoPennLINC:mainfrom
Closed
Replace MCFLIRT-based HMC workflow with ANTs-based one#506tsalo wants to merge 36 commits intoPennLINC:mainfrom
tsalo wants to merge 36 commits intoPennLINC:mainfrom
Conversation
tsalo
commented
Apr 28, 2025
Comment on lines
+182
to
+183
| (reference_buffer, register_reference, [('aslref', 'fixed_image')]), | ||
| (inputnode, register_reference, [('raw_ref_image', 'moving_image')]), |
Member
Author
There was a problem hiding this comment.
This is the opposite of what I would expect, but having it swapped produced bad results.
tsalo
commented
Apr 28, 2025
tsalo
commented
Apr 28, 2025
Member
Author
|
I'm currently having trouble making the right associated files (motion parameters file, RMSD file) from the ITK transforms. |
Member
Author
|
Closing for now. If mutual information doesn't work, and volume type-specific reference images also doesn't work, then we can revisit this idea (or try NiFreeze). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes none, but addresses a bug I found. It looks like GE processing was still running HMC.
One remaining problem is that there's no transform from the ASL file to the aslref image.
Changes proposed in this pull request