Fix writable check for NFS/ACL filesystems#348
Merged
tien-tong merged 1 commit intoPennLINC:mainfrom Mar 18, 2026
Merged
Conversation
os.access() is unreliable on NFS and ACL-based filesystems. Use tempfile.TemporaryFile() to actually test write access. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 79.30% 79.34% +0.04%
==========================================
Files 16 16
Lines 1841 1845 +4
Branches 312 311 -1
==========================================
+ Hits 1460 1464 +4
- Misses 266 267 +1
+ Partials 115 114 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tien-tong
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.access() is unreliable on NFS and ACL-based filesystems. Use tempfile.TemporaryFile() to actually try write access.