-
Notifications
You must be signed in to change notification settings - Fork 57
Update llvm, 2025 Q3 #1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update llvm, 2025 Q3 #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Merged
paul0403
commented
Jul 22, 2025
paul0403
commented
Jul 22, 2025
This comment was marked as outdated.
This comment was marked as outdated.
paul0403
commented
Jul 22, 2025
|
@mehrdad2m @dime10 this is now completely ready |
mehrdad2m
reviewed
Jul 28, 2025
Co-authored-by: Mehrdad Malek <[email protected]>
dime10
requested changes
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paul0403, just two points:
dime10
reviewed
Jul 28, 2025
dime10
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
mehrdad2m
approved these changes
Jul 28, 2025
github-merge-queue bot
pushed a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Aug 15, 2025
**Context:** Catalyst is updating LLVM, which includes a redefinition of this operation in the transform dialect. Note: Only merge after PennyLaneAI/catalyst#1916 **Description of the Change:** Redefine the ApplyRegisteredPass in the transform dialect to support Catalyst's generic format. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-96972] --------- Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: Mehrdad Malekmohammadi <[email protected]> Co-authored-by: Mehrdad Malek <[email protected]>
github-merge-queue bot
pushed a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Aug 15, 2025
**Context:** Catalyst is updating LLVM, which includes a redefinition of this operation in the transform dialect. Note: Only merge after PennyLaneAI/catalyst#1916 **Description of the Change:** Redefine the ApplyRegisteredPass in the transform dialect to support Catalyst's generic format. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-96972] --------- Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: Mehrdad Malekmohammadi <[email protected]> Co-authored-by: Mehrdad Malek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Update llvm, mhlo and enzyme, 2025 Q3.
The latest pair of good versions, indicated by mhlo, is tensorflow/mlir-hlo@1dd2e71
For Enzyme, we go to the latest release https://github.com/EnzymeAD/Enzyme/releases/tag/v0.0.186
with commit
8c1a596158f6194f10e8ffd56a1660a61c54337eDescription of the Change:
Miscellaneous:
GreedyRewriteConfig.stuff = blah->GreedyRewriteConfig.setStuff(blah)[mlir] add a fluent API to GreedyRewriterConfig llvm/llvm-project#137122inboundsattribute is subsumed under a gep sign wrap enum flag [mlir][llvm] Support nusw and nuw in GEP llvm/llvm-project#137272arith::Constant[Int, Float]Opbuilders now have the same argument order as other ops (output type first, then arguments) switch type and value ordering for arithConstant[XX]Opllvm/llvm-project#144636 (note that Enzyme also noticed this Update to newer llvm EnzymeAD/Enzyme#2379 😆 )lookupOrCreateFnfunctions now take in a builder instead of instantiating a new one [mlir][LLVM] AddOpBuilder &tolookupOrCreateFnfunctions llvm/llvm-project#136421getStridedElementPtrnow takes inrewriteras the first argument (instead of the last), like all the other utils emit inbounds and nuw attributes in memref. llvm/llvm-project#138984LogicalResult, and will be caught by warnings as errors as-Wunused-result:func::FuncOp.[insert, erase]Argument(s)[mlir] allow function type cloning to fail llvm/llvm-project#137130getBackwardSlice()[MLIR] Change getBackwardSlice to return a logicalresult rather than crash llvm/llvm-project#140961Things related to
transform.apply_registered_passop:dynamic_options[MLIR][Transform] Allow ApplyRegisteredPassOp to take options as a param llvm/llvm-project#142683. We don't need to use this as all our pass options are static.Bufferization:
bufferization.to_memrefop is renamed tobufferization.to_buffer[mlir][bufferization][NFC] Rename to_memref to to_buffer llvm/llvm-project#137180bufferization.to_tensorop's builder now needs the result type to be explicit [mlir][bufferization] Support custom types (1/N) llvm/llvm-project#142986. This is also needed by a patched mhlo pass.getBuffer()methods take in a new arg forBufferizationState[MLIR] Add bufferization state class to OneShotBufferization pass llvm/llvm-project#141019, [MLIR] Add bufferization state togetBufferTypeandresolveConflictsinterface methods llvm/llvm-project#141466UnknownTypeConverterFnin bufferization options now takes in just a type instead of a full value [mlir][bufferization] Use Type instead of Value in unknown conversion llvm/llvm-project#144658Related GitHub Issues:
[sc-95176]
[sc-95664]