Skip to content

Conversation

rniczh
Copy link
Contributor

@rniczh rniczh commented Sep 30, 2025

Context:

Description of the Change:
Added traversal logic of mcm. For an example, finding the qreg and index of qb3 in the following case, it needs to traverse the def-use chain through the ops.

qb0 = extract(...)
...
meas_result, qb2 = qml.measure(qb1, 0)
...
qb4 = op(qb3, ...) 

Refactoring

  1. Use QuantumGate to traverse the gates instead of CustomOp
  2. Collect qreg and qubit index with only one walk

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-100311]

@rniczh rniczh requested a review from maliasadi September 30, 2025 13:41
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v0.13.0-rc@627958d). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             v0.13.0-rc    #2068   +/-   ##
=============================================
  Coverage              ?   97.47%           
=============================================
  Files                 ?       91           
  Lines                 ?    10607           
  Branches              ?      995           
=============================================
  Hits                  ?    10339           
  Misses                ?      213           
  Partials              ?       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rniczh rniczh requested a review from a team October 2, 2025 19:54
@rniczh rniczh changed the title Add support of MCM for decompose pass Add support of MCM for decompose pass and some refactoring Oct 3, 2025
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rniczh! Could you add tests here to check the integration w/ graph decomp?

paul0403 and others added 5 commits October 6, 2025 17:07
Context: Setting up the repository for the next development cycle after
v13 release.

Description of the Change:
- Add new changelog-dev.md file for v0.14.0
- Add changelog-dev reference to release_notes.rst
- Update version in _version.py to 0.14.0-dev0
- Update rc_sync.yml for release manager name
- Update build-nightly-release-candidate.yaml's schedule for this
release

---------

Co-authored-by: Mehrdad Malek <[email protected]>
Automatic sync from the release candidate to main during a feature
freeze.

---------

Co-authored-by: Jeffrey Kam <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Paul <[email protected]>
Co-authored-by: GitHub Actions Bot <>
Co-authored-by: paul0403 <[email protected]>
@rniczh rniczh changed the base branch from main to v0.13.0-rc October 7, 2025 15:32
@rniczh rniczh added this to the v0.13.0 milestone Oct 7, 2025
@rniczh rniczh requested a review from maliasadi October 7, 2025 15:41
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⚡

@dime10 dime10 requested a review from a team October 8, 2025 19:17
Copy link
Contributor

@sengthai sengthai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me so far. It would be great if those helper functions can be used in the across passes in the project. 👍

Copy link
Contributor

@sengthai sengthai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👍 🚀

@rniczh rniczh merged commit 297b710 into v0.13.0-rc Oct 9, 2025
44 checks passed
@rniczh rniczh deleted the rniczh/add-mcm-support-decompose branch October 9, 2025 20:19
@rniczh rniczh restored the rniczh/add-mcm-support-decompose branch October 10, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants