-
Notifications
You must be signed in to change notification settings - Fork 57
Higher order primitives can take in dynamically allocated registers #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paul0403
wants to merge
20
commits into
main
Choose a base branch
from
paul0403/multiple_registers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Higher order primitives can take in dynamically allocated registers
Description of the Change:
Benefits:
Possible Drawbacks:
Don't know why, but while other subregions have arg signature
(args, qreg)
, subroutine has signature(qreg, args)
, i.e. it has args in reverse order. This means the subregion wrapper (the thing to bemake_jaxpr
'd) cannot be reused for subroutines.This is probably something we can just reorder?
Also, subroutine takes in wire indices through tracer args of the subroutine, even when the indices are static. This means its
qreg_map
logic between inner qregs and outer qregs is different than the others.Related GitHub Issues:
[sc-99734]