Higher order primitives can take in dynamically allocated registers #2130
+547
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
==========================================
- Coverage 97.43% 97.41% -0.03%
==========================================
Files 92 92
Lines 10613 10465 -148
Branches 998 1013 +15
==========================================
- Hits 10341 10194 -147
+ Misses 214 213 -1
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Higher order primitives can take in dynamically allocated registers
Description of the Change:
Benefits:
Possible Drawbacks:
Don't know why, but while other subregions have arg signature
(args, qreg), subroutine has signature(qreg, args), i.e. it has args in reverse order. This means the subregion wrapper (the thing to bemake_jaxpr'd) cannot be reused for subroutines.This is probably something we can just reorder?
Also, subroutine takes in wire indices through tracer args of the subroutine, even when the indices are static. This means its
qreg_maplogic between inner qregs and outer qregs is different than the others.Related GitHub Issues:
[sc-99734]