Skip to content

Conversation

@paul0403
Copy link
Member

@paul0403 paul0403 commented Oct 20, 2025

Context:
Recently plxpr pipeline's control flow handling of consts for subscope body jaxprs were updated, but one place was missed in the update. #2128

Description of the Change:
handle_for_loop correctly uses length of new_consts.

Benefits:
Things are correct.

@paul0403 paul0403 requested review from a team and albi3ro October 20, 2025 20:52
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.39%. Comparing base (6c68848) to head (c32b845).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2133      +/-   ##
==========================================
- Coverage   97.42%   97.39%   -0.03%     
==========================================
  Files          91       91              
  Lines       10610    10610              
  Branches      999      999              
==========================================
- Hits        10337    10334       -3     
- Misses        216      218       +2     
- Partials       57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paul0403 paul0403 merged commit 07add14 into main Oct 20, 2025
40 checks passed
@paul0403 paul0403 deleted the paul0403/consts_small_fix branch October 20, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants