Add PLModulePass to abstract away low-level details of xDSL's ModulePass
#2211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neAI/catalyst into migrate-unified-compiler
…_in_dim verify methods
mudit2812
changed the title
PLModulePass
**Context:** Migrates the `chore/xdsl-utils` branch from PennyLane. **Description of the Change:** Renames the visualization module to inspection and improves several xDSL parsing utilities within the python interface. **Benefits:** Simplifies and augments existing utility functions within the ~visualization~ inspection module **Possible Drawbacks:** **Related GitHub Issues:** [sc-104851]
…neAI/catalyst into migrate-unified-compiler
mudit2812
commented
Dec 2, 2025
Comment on lines
+148
to
+150
| # xdsl.pattern_rewriter.op_type_rewrite_pattern was used as a reference to | ||
| # implement the type hint collection. Source: | ||
| # https://github.com/xdslproject/xdsl/blob/main/xdsl/pattern_rewriter.py |
Contributor
Author
There was a problem hiding this comment.
xDSL uses the Apache 2.0 license, so this should be fine, right? The functionality mentioned in this comment is not something that does anything actually related to xDSL or compilation either.
Contributor
|
Hello. You may have forgotten to update the changelog!
|
mudit2812
commented
Dec 2, 2025
Contributor
Author
There was a problem hiding this comment.
This file will be removed before merging the PR.
mudit2812
changed the title
PLModulePassPLModulePass to abstract away low-level details of xDSL's ModulePass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of PennyLaneAI/pennylane#8617
[sc-103609]