Skip to content

Conversation

@JerryChen97
Copy link
Contributor

@JerryChen97 JerryChen97 commented Aug 13, 2025

Context:
As we have already implemented the _validate_mcmc_options helper to directly check mcmc options in execution config constructor, it is also important to have it actually added to the preprocess pipeline since with the decoupling between shots and device the only scenario when a device can get and validate the shots information will be the preprocess.
Given that, we would like to add the validator as a transform as well as keeping the original helper, before we entirely remove shots from Device on the PennyLane side (which should take a very long time).

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-103749]

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.69%. Comparing base (483c4d6) to head (4274977).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
+ Coverage   93.77%   94.69%   +0.91%     
==========================================
  Files         183      180       -3     
  Lines       30380    29307    -1073     
==========================================
- Hits        28490    27751     -739     
+ Misses       1890     1556     -334     
Flag Coverage Δ
unit_tests 94.69% <100.00%> (+0.91%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants