Merged
Conversation
josephleekl
commented
Feb 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
- Coverage 95.58% 94.83% -0.75%
==========================================
Files 243 187 -56
Lines 40039 28815 -11224
==========================================
- Hits 38272 27328 -10944
+ Misses 1767 1487 -280
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
josephleekl
commented
Feb 4, 2026
josephleekl
commented
Feb 4, 2026
josephleekl
commented
Feb 4, 2026
This comment has been minimized.
This comment has been minimized.
josephleekl
commented
Feb 5, 2026
josephleekl
commented
Feb 5, 2026
JerryChen97
reviewed
Feb 5, 2026
maliasadi
approved these changes
Feb 5, 2026
Member
maliasadi
left a comment
There was a problem hiding this comment.
Thanks @josephleekl!
Don't forget to update the changelog :)
jzaia18
approved these changes
Feb 5, 2026
Contributor
jzaia18
left a comment
There was a problem hiding this comment.
Thanks for the fix, just don't forget to create a story for after the release
Co-authored-by: Luis Alfredo Nuñez Meneses <alfredo.nunez@xanadu.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
There are several issues causing our CIs to fail:
Description of the Change:
We introduce a temporary patch (which needs to be removed in the next release cycle) to install test dependencies with
pip install -r requirements-tests.txt(the old way) for stable CI runs.We updated the fixture to be compliant with pytest 9.0.For stable test, this is not reflected, so we pull the older version of pytest, which will also be removed in the next release cycle.
We apply the same fix applied before to an offending test in the mpitests
We update the argument type of
wire_orderin a testBenefits:
stable/stable and latest/latest CIs both pass again.
Possible Drawbacks:
Related GitHub Issues:
[sc-110620]