Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
- Coverage 95.73% 91.47% -4.27%
==========================================
Files 243 187 -56
Lines 40937 29110 -11827
==========================================
- Hits 39191 26628 -12563
- Misses 1746 2482 +736
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
josephleekl
left a comment
There was a problem hiding this comment.
Thanks @runora95 for this, this is a useful addition!
Added some comments. This is probably hard to test, and we may uncover bugs around release, but not sure if there's anything we can do here.
Also, could you help us check whether .github/workflows/pre_release_version_bump.yml and .github/workflows/vb_script.py are completely obsolete now, and if so can you remove them too?
Please tag me again once these have been addressed.
josephleekl
left a comment
There was a problem hiding this comment.
two more quick comments - happy to approve after this
Co-authored-by: Joseph Lee <40768758+josephleekl@users.noreply.github.com>
Co-authored-by: Joseph Lee <40768758+josephleekl@users.noreply.github.com>
**Context:** This is part of the nightly release automation synchronization with catalyst and lightning where the uploads to TestPyPI are done in the following order: Lightning —> Catalyst —> Pennylane. Pennylane's RC branch builds will be triggered by a successful run of Catalysts build. **Description of the Change:** Removing the scheduled run on the nightly RC builds. **Benefits:** RC branch TestPyPI builds are synchronized. **Possible Drawbacks:** None. **Related GitHub Issues:** PennyLaneAI/catalyst#2491 PennyLaneAI/pennylane-lightning#1344
**Context:** This is part of the nightly release automation synchronization with pennylane and lightning where the uploads to TestPyPI are done in the following order: Lightning —> Catalyst —> Pennylane. Catalysts RC branch builds will be triggered by a successful run of Lightning's build. **Description of the Change:** Updating nightly RC builds to remove scheduled run, added a trigger for pennylane. **Benefits:** RC branch TestPyPI builds are synchronized. **Possible Drawbacks:** None. **Related GitHub Issues:** PennyLaneAI/pennylane-lightning#1344 PennyLaneAI/pennylane#9092 --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
**Context:** This is part of the nightly release automation synchronization with pennylane and lightning where the uploads to TestPyPI are done in the following order: Lightning —> Catalyst —> Pennylane. Catalysts RC branch builds will be triggered by a successful run of Lightning's build. **Description of the Change:** Updating nightly RC builds to remove scheduled run, added a trigger for pennylane. **Benefits:** RC branch TestPyPI builds are synchronized. **Possible Drawbacks:** None. **Related GitHub Issues:** PennyLaneAI/pennylane-lightning#1344 PennyLaneAI/pennylane#9092 --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
**Context:** This is part of the nightly release automation synchronization with pennylane and lightning where the uploads to TestPyPI are done in the following order: Lightning —> Catalyst —> Pennylane. Catalysts RC branch builds will be triggered by a successful run of Lightning's build. **Description of the Change:** Updating nightly RC builds to remove scheduled run, added a trigger for pennylane. **Benefits:** RC branch TestPyPI builds are synchronized. **Possible Drawbacks:** None. **Related GitHub Issues:** PennyLaneAI/pennylane-lightning#1344 PennyLaneAI/pennylane#9092 --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Context:
This is part of the nightly release automation synchronization with pennylane and catalyst where the uploads to TestPyPI are done in the following order: Lightning —> Catalyst —> Pennylane. A new workflow to upload wheels built from the RC branch will be added and run on a schedule. The workflow will also trigger Catalyst's rc nightly build.
Description of the Change:
Added workflow to update the RC version number, build and push nightly builds of the RC branch to TestPyPi, and trigger the nightly build of Catalyst. The build wheel workflows were also updated to run with the nightly builds.
Benefits:
RC branch TestPyPI builds are synchronized.
Possible Drawbacks:
None
Related GitHub Issues:
PennyLaneAI/catalyst#2491
PennyLaneAI/pennylane#9092