Fix a bug with Barrier not being supported in Azure-qiskit #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #677 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 862 861 -1
=========================================
- Hits 862 861 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Probably need to explicitly fmt the tests by |
JerryChen97
reviewed
Jan 22, 2026
lillian542
reviewed
Jan 22, 2026
Comment on lines
-715
to
-716
| # barrier ensures we first do all operations, then do all measurements | ||
| qc.barrier(reg) |
Contributor
There was a problem hiding this comment.
This and the related changes in tests/test_converter.py is the actual change. Everything else is black formatting.
JerryChen97
approved these changes
Jan 22, 2026
JerryChen97
reviewed
Jan 22, 2026
Contributor
JerryChen97
left a comment
JerryChen97
left a comment
There was a problem hiding this comment.
Actually, mind adding a changelog? @DSGuala @lillian542
JerryChen97
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The current circuit conversion inserts a
barrierbetween thetape.operationsand the terminal measurements when converting a PL circuit to a Qiskit circuit. Some devices don't supportbarrier, and as far as we can see, it isn't technically necessary.Description of the Change:
This PR removes a line in
circuit_to_qiskitthat added a barrier between a circuit's gates and measurements.Also the new version of
blackhas added some extra whitespace etc. There are only 4 lines of actual changes.Benefits:
Allows devices like Azure that don't include
barriersupport to work with the Remote device.Possible Drawbacks:
We aren't aware of anything that was dependent on the
barrier, and removing it doesn't cause any tests to fail, but it's not impossible that some device somewhere was expecting it to be there. We can cross that bridge if we come to it.Related GitHub Issues:
PennyLaneAI/pennylane#8657
[sc-104090]