Skip to content

fix(moduleloader): isolate module namespaces and cache loaded modules #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marshall-Hallenbeck wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −5
Open

fix(moduleloader): isolate module namespaces and cache loaded modules #1132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions nxc/loaders/moduleloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import sys

from os import listdir
from os.path import dirname
from os.path import basename, dirname
from os.path import join as path_join

from nxc.context import Context
Expand Down Expand Up @@ -46,11 +46,29 @@ def module_is_sane(self, module, module_path):

return not module_error

module_cache = {}

@classmethod
def load_module_file(cls, module_path):
"""Load a module file and return the raw module object with isolated namespace.

Each module gets a unique name to avoid sys.modules collisions that
caused NXCModule class references to be overwritten when loading
multiple modules. Results are cached so each file is only parsed
and executed once regardless of how many targets are scanned.
"""
if module_path not in cls.module_cache:
module_name = f"nxc_module_{basename(module_path)[:-3]}"
spec = importlib.util.spec_from_file_location(module_name, module_path)
module = importlib.util.module_from_spec(spec)
spec.loader.exec_module(module)
Copy link
Member

@NeffIsBack NeffIsBack Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exec_module() tho?

cls.module_cache[module_path] = module
return cls.module_cache[module_path]

def load_module(self, module_path):
"""Load a module, initializing it and checking that it has the proper attributes"""
try:
spec = importlib.util.spec_from_file_location("NXCModule", module_path)
module = spec.loader.load_module().NXCModule()
module = self.load_module_file(module_path).NXCModule()

if self.module_is_sane(module, module_path):
return module
Expand Down Expand Up @@ -87,8 +105,7 @@ def init_module(self, module_path):
def get_module_info(self, module_path):
"""Get the path, description, and options from a module"""
try:
spec = importlib.util.spec_from_file_location("NXCModule", module_path)
module_spec = spec.loader.load_module().NXCModule
module_spec = self.load_module_file(module_path).NXCModule

module = {
f"{module_spec.name}": {
Expand Down