PS-10239 feature: Add support for processing GTID_LOG events#73
Merged
percona-ysorokin merged 1 commit intomainfrom Oct 31, 2025
Merged
PS-10239 feature: Add support for processing GTID_LOG events#73percona-ysorokin merged 1 commit intomainfrom
percona-ysorokin merged 1 commit intomainfrom
Conversation
https://perconadev.atlassian.net/browse/PS-10239 Added new template specializations for 'generic_post_header_impl' and 'generic_body_impl' for 'code_type::gtid_log' ('GTID_LOG' event). Reworked / generalized 'util::extract_xxx()` series of functions - they now have corresponding "checked" versions that verify whether required number of bytes is available in the input data span and return false otherwise. Added 'util::extract_packed_int_from_byte_span_checked()' helper function that extracts 'std::uint64_t' integer from its packed network representation (MySQL-specific format). Added 'binsrv/gtid/common_types.hpp' file with basic typedefs for future GTID structures. 'binsrv::events::flag_type' renamed to 'binsrv::events::common_header_flag_type'.
percona-ysorokin
force-pushed
the
gtid_log_event
branch
from
f7c4932 to
90d83c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-10239
Added new template specializations for 'generic_post_header_impl' and 'generic_body_impl' for 'code_type::gtid_log' ('GTID_LOG' event).
Reworked / generalized 'util::extract_xxx()` series of functions - they now have corresponding "checked" versions that verify whether required number of bytes is available in the input data span and return false otherwise.
Added 'util::extract_packed_int_from_byte_span_checked()' helper function that extracts 'std::uint64_t' integer from its packed network representation (MySQL-specific format).
Added 'binsrv/gtid/common_types.hpp' file with basic typedefs for future GTID structures.
'binsrv::events::flag_type' renamed to 'binsrv::events::common_header_flag_type'.