PS-10245 feature: Implement receiving binlog events in GTID mode (part 3)#83
Merged
percona-ysorokin merged 1 commit intomainfrom Dec 22, 2025
Merged
Conversation
…t 3) https://perconadev.atlassian.net/browse/PS-10245 Implemented more sophisticated model of 'binstv::event::reader_context' state machine. Instead of (ROTATE(artificial) FORMAT_DESCRIPTION <ANY>* (ROTATE|STOP)?)+ we now also track GTID-related events and transaction boundaries ( ROTATE(artificial) FORMAT_DESCRIPTION PREVIOUS_GTIDS_LOG? ((ANONYMOUS_GTID_LOG | GTID_LOG | GTID_TAGGED_LOG) <ANY>*)* (ROTATE | STOP)? )+ Implemented additional method 'is_at_transaction_boundary()' that can be used to check if we reached the end of transaction after processing the event. Main application extended with simplified transaction event logging at 'info' level: - we now write simple messages with event code types and event flags if any (e.g. 'artificial') - we also write corresponding GTIDs at the end of transactions. Added new 'binlog_streaming.kill_and_restart' MTR test case which checks for different endings of binlog files after rotation: - normal 'ROTATE' event (after 'FLUSH BINARY LOGS') - normal 'STOP' event (after server shutdown) - termination without 'ROTATE' / 'STOP' event (in case server crashed / was killed and restarted) - currently open binlog file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-10245
Implemented more sophisticated model of 'binstv::event::reader_context' state machine. Instead of
(ROTATE(artificial) FORMAT_DESCRIPTION * (ROTATE|STOP)?)+ we now also track GTID-related events and transaction boundaries (
ROTATE(artificial)
FORMAT_DESCRIPTION
PREVIOUS_GTIDS_LOG?
((ANONYMOUS_GTID_LOG | GTID_LOG | GTID_TAGGED_LOG) )
(ROTATE | STOP)?
)+
Implemented additional method 'is_at_transaction_boundary()' that can be used to check if we reached the end of transaction after processing the event.
Main application extended with simplified transaction event logging at 'info' level:
Added new 'binlog_streaming.kill_and_restart' MTR test case which checks for different endings of binlog files after rotation: