Fix pm_to_blib for VMS #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
154730c broke the core build on VMS. The one-liner is not parseable and it turns out to be due to a bug in the make utility (MMK) wherein the comment character ('#') does not get ignored within a quoted string on a continuation line (it's fine on the first line of a rule). So squirrel away $#ARGV and its '#' character in another variable on the first line, where it causes no trouble, then use the substitute on the second line. Also, replace literal quote characters with the q operator where it's easy to do so; it's a lot easier to read and debug the generated code if you don't have to think about all of the quoting and escaping and interpolation rules regarding single and double quotes for Perl, the make utility, and the shell all at once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
154730c broke the core build on VMS. The one-liner is not parseable and it turns out to be due to a bug in the make utility (MMK) wherein the comment character ('#') does not get ignored within a quoted string on a continuation line (it's fine on the first line of a rule). So squirrel away $#ARGV and its '#' character in another variable on the first line, where it causes no trouble, then use the substitute on the second line.
Also, replace literal quote characters with the q operator where it's easy to do so; it's a lot easier to read and debug the generated code if you don't have to think about all of the quoting and escaping and interpolation rules regarding single and double quotes for Perl, the make utility, and the shell all at once.