Skip to content

Support 'class' VERSIONs, like 'package' #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

Support 'class' VERSIONs, like 'package' #474

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a630b47
Support 'class' VERSIONs, like 'package'
ehuelsmann Jul 12, 2025
138d823
Add support for package attributes
ehuelsmann Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ExtUtils/MM_Unix.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3029,7 +3029,7 @@ sub parse_version {
next if $inpod || /^\s*#/;
chop;
next if /^\s*(if|unless|elsif)/;
if ( m{^ \s* package \s+ \w[\w\:\']* \s+ (v?[0-9._]+) \s* (;|\{) }x ) {
if ( m{^ \s* (?:package|class) \s+ \w[\w\:\']* \s+ (v?[0-9._]+) \s* (;|\{) }x ) {
no warnings;
$result = $1;
}
Expand Down
18 changes: 18 additions & 0 deletions t/parse_version.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,24 @@ our $VERSION = 2.34;
END
}

if ( "$]" >= 5.038 ) {
$versions{'class Foo 1.23;' } = '1.23';
$versions{'class Foo::Bar 1.23;' } = '1.23';
$versions{'class Foo v1.2.3;' } = 'v1.2.3';
$versions{'class Foo::Bar v1.2.3;' } = 'v1.2.3';
$versions{' class Foo::Bar v1.2.3;' } = 'v1.2.3';
$versions{"class Foo'Bar 1.23;" } = '1.23';
$versions{'class Foo 1.230;' } = '1.230';

$versions{'class Foo 1.23 { }' } = '1.23';
$versions{'class Foo::Bar 1.23 { }' } = '1.23';
$versions{'class Foo v1.2.3 { }' } = 'v1.2.3';
$versions{'class Foo::Bar v1.2.3 { }' } = 'v1.2.3';
$versions{' class Foo::Bar v1.2.3 { }' } = 'v1.2.3';
$versions{"class Foo'Bar 1.23 { }" } = '1.23';
$versions{'class Foo 1.230 { }' } = '1.230';
}

if ( "$]" < 5.012 ) {
delete $versions{'$VERSION = -1.0'};
}
Expand Down
Loading