Skip to content

Commit 40065a2

Browse files
committed
fix type of S_unwind_scan_frames
This function is registered with SAVEDESTRUCTOR_X, so its type must be 'void (pTHX_ void *)' exactly. (Also, there is no point in declaring p pointer-to-const since we cast away 'const' three lines down anyway.) I don't know if this change has any practical impact, but it shows up in ASan output: scope.c:1543:13: runtime error: call to function S_unwind_scan_frames through pointer to incorrect function type 'void (*)(struct interpreter *, void *)'
1 parent cf50778 commit 40065a2

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

embed.fnc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5679,7 +5679,7 @@ ES |void |ssc_union |NN regnode_ssc *ssc \
56795679
|NN SV * const invlist \
56805680
|const bool invert_2nd
56815681
ES |void |unwind_scan_frames \
5682-
|NN const void *p
5682+
|NN void *p
56835683
#endif /* defined(PERL_IN_REGCOMP_STUDY_C) */
56845684
#if defined(PERL_IN_REGEXEC_C)
56855685
ERS |LB_enum|advance_one_LB |NN U8 **curpos \

proto.h

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

regcomp_study.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626

2727
STATIC void
28-
S_unwind_scan_frames(pTHX_ const void *p)
28+
S_unwind_scan_frames(pTHX_ void *p)
2929
{
3030
PERL_ARGS_ASSERT_UNWIND_SCAN_FRAMES;
3131
scan_frame *f= (scan_frame *)p;

0 commit comments

Comments
 (0)