Skip to content

Conversation

@jidanni
Copy link
Member

@jidanni jidanni commented Dec 8, 2024

@Grinnz
Copy link
Contributor

Grinnz commented Dec 8, 2024

It doesn't make much difference, but I don't think this is an improvement. The previous sentence indicates that it operates on @ARGV sometimes and @_ other times; this sentence lists other constructs where it will operate on @ARGV and not @_; so it is not an addition to the previous sentence, but an exception to the second half of it.

As an unrelated nitpick, the pop and shift sections should be kept corresponding.

@jkeenan
Copy link
Contributor

jkeenan commented Mar 19, 2025

The original poster has not responded to @Grinnz's critique of the p.r. I am marking this ticket "Closable?"

@jkeenan jkeenan added the Closable? We might be able to close this ticket, but we need to check with the reporter label Mar 19, 2025
@jidanni
Copy link
Member Author

jidanni commented Mar 21, 2025

The original poster has not responded to @Grinnz's critique of the p.r. I am marking this ticket "Closable?"

I did, using the "eyeballs" reaction choice. As this is all beyond my Perl level, so I'll leave it in the hands of the pros.

@jkeenan jkeenan closed this Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Closable? We might be able to close this ticket, but we need to check with the reporter documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants