Perl_vnewSVpvf - use the pattern length to size the new PV buffer #23101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function currently creates a new SVt_PV with a minimum string
length buffer via:
sv = newSV(1);
Simple measurements from compiling perl show that this is often sufficient.
When it isn't, the final buffer length is often close to strlen(pat).
Common cases that require a realloc() now will not with this commit. In
other cases, realloc()s will still be required, but the number will
likely be smaller by one.
Although min length & alloc behaviour can vary across platforms and
compilers, the following numbers are likely indicative:
|strlen(pat)|Inital SvLEN before|Initial SvLEN now|Final SvLEN|
|-----------|-------------------|-----------------|-----------|
|004|16|016|016|
|058|16|060|060|
|071|16|073|120|
|104|16|106|106|
|104|16|106|200|
|122|16|124|124|
|123|16|125|125|
|123|16|125|168|
|377|16|379|379|
richardleach
force-pushed
the
vnewSVpvf_patsize
branch
from
baac5e7 to
744484e
Compare
mauke
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function currently creates a new
SVt_PVwith a minimum string length buffer via:Simple measurements from compiling perl show that this is often sufficient.
When it isn't, the final buffer length is often close to
strlen(pat). Common cases that require arealloc()now will not with this commit. In other cases,realloc()s will still be required, but the number will likely be smaller by one.Although min length & alloc behaviour can vary across platforms and compilers, the following numbers are likely indicative: