PathTools: check Config values early before chdir #23166
Merged
+15
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a perl core build, the
@INCpaths will be relative. If you change directories before loading all of the files needed, they won't be able to be found.Config.pmloads some of its values at runtime, so if they are accessed after achdir, it may fail.One of the
PathToolstests was relying on the fact thatConfig_heavy.plwould be loaded byTest::More, before it did achdir. NewerTest::Morewon't do that, so the test would fail. Accessing the requiredConfigvalues early will prevent this failure.This same issue is unlikely to impact anything outside core, as it requires the perl core paths in
@INCto be relative paths, which is normally not the case.Fixes #23164