dist-modules: fix selection of a threaded perl #23167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect I broke this when I re-worked it to add the pretty labels.
This was failing for threads.pm, threads-shared, Thread-Semaphore under 5.8.9 threaded. I wasn't able to make these fail with my local copy of 5.8.9 threaded. These are failing with messages like: Unbalanced string table refcount: (0) for "TRAP" during global destruction. Unbalanced string table refcount: (0) for "ERRNO" during global destruction. Unbalanced string table refcount: (0) for "setuid" during global destruction. Unbalanced string table refcount: (0) for "POSIX.pm" during global destruction. Unbalanced string table refcount: (0) for "SKIP" during global destruction. Unbalanced string table refcount: (0) for "load" during global destruction. Unbalanced string table refcount: (0) for "register::" during global destruction. Unbalanced string table refcount: (0) for "_filters" during global destruction. Unbalanced string table refcount: (0) for "gen_uid" during global destruction. Unbalanced string table refcount: (0) for "==" during global destruction. Unbalanced string table refcount: (0) for "FINALIZED" during global destruction. Unbalanced string table refcount: (0) for "event_tap" during global destruction. Unbalanced string table refcount: (0) for "confess" during global destruction. Unbalanced string table refcount: (0) for "CAN_SIGSYS" during global destruction. Unbalanced string table refcount: (0) for "NUM56" during global destruction. Unbalanced string table refcount: (0) for "tv_interval" during global destruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at the test results of a PR recently and when drilling down into the threaded results noticed we weren't actually testing against old threaded perls.
I suspect I broke this when I re-worked it to add the pretty labels, since the original patch set here did fix some threaded build issues detected by these tests.