Skip to content

Conversation

@happy-barney
Copy link

@happy-barney happy-barney commented May 31, 2025

Most of` changes of original PR were merged in #23740

What is left is ordering keywords alphabetically.

  • This set of changes does not require a perldelta entry.

@mauke
Copy link
Contributor

mauke commented Sep 19, 2025

Fun fact: This is pretty much the opposite of commit c2f605d.

@mauke
Copy link
Contributor

mauke commented Sep 19, 2025

At least some of the failures are because of #23737.

@happy-barney
Copy link
Author

happy-barney commented Sep 20, 2025

At least some of the failures are because of #23737.

failures in op/coreamp.t and op/coresubs.t are caused by previous magic:

  • KEY___PACKAGE__ had code 0, KEY___CLASS__ had code -3; with -code % 3 both resulting 0

Motivation behind this PR is to avoid exactly this kind of magic - 7424673

@mauke
Copy link
Contributor

mauke commented Sep 20, 2025

I'd ask you to put this PR on hold for a moment until #23740 is merged. It fixes the __CLASS__ issue and also removes the -code % 3 logic (which previously hid this bug from tests).

Then this PR would reduce to simply sorting the list keywords in regen/keywords.pl, I believe.

@happy-barney happy-barney changed the title Cleanup - break positional requirement of keywords [regen/keywords] Order keywords alphabetically Sep 22, 2025
@happy-barney
Copy link
Author

PR rebased

@thibaultduponchelle thibaultduponchelle merged commit 322d8a0 into Perl:blead Sep 22, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants