-
Notifications
You must be signed in to change notification settings - Fork 602
[regen/keywords] Order keywords alphabetically #23343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02a7516 to
e4c183c
Compare
mauke
reviewed
Sep 19, 2025
Contributor
|
Fun fact: This is pretty much the opposite of commit c2f605d. |
Contributor
|
At least some of the failures are because of #23737. |
Author
Contributor
|
I'd ask you to put this PR on hold for a moment until #23740 is merged. It fixes the Then this PR would reduce to simply sorting the list keywords in |
7424673 to
ff23cea
Compare
Author
|
PR rebased |
mauke
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of` changes of original PR were merged in #23740
What is left is ordering keywords alphabetically.