Skip to content

Conversation

@thibaultduponchelle
Copy link
Member

I am unhappy with the "Update Module::CoreList" sections.

Changes

  • Move most common command first
  • Make the section smaller
  • Link to email thread with details on handling Module::CoreList for MAINT releases

  • This set of changes does not require a perldelta entry.

@thibaultduponchelle
Copy link
Member Author

@iabyn

@iabyn
Copy link
Contributor

iabyn commented Jul 6, 2025

I can't really comment. The wording I added to the RMG 12 years ago just reflected that at the time, handling Module::CoreList was complex as it lived in all branches and needed to be consistently version-bumped. I can't remember the details, and I have no idea what (if anything) has changed or improved in the meantime.

$ ./perl -Ilib Porting/corelist.pl ~/my-cpan-mirror

Otherwise, run:
In most cases, run:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this wording very much.

To me the "in most cases" is meaningless because when reading that I will start wondering if my current case is part of the "most cases" or if it's one of the exception cases..

(From just the diff it's not clear if/when "most cases" apply, maybe it's from the rest of the context but I didn't read that yet)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it by specifying which type of releases are actually concerned

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks better.

The only thing that still bothers me slightly is that it's now unclear what needs to happen for MAINT releases..

While I get that the old section is confusing and annoying and cryptic it might still be better than nothing.. :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I get the point and you're right. I reinstalled the useful bits from the old section :)

@jkeenan
Copy link
Contributor

jkeenan commented Sep 2, 2025

@bingos would you like to comment on this pull request re corelist? Thanks.

@thibaultduponchelle thibaultduponchelle force-pushed the rmg_improve_corelist_section branch from 96af425 to 2569225 Compare September 25, 2025 11:47
@thibaultduponchelle
Copy link
Member Author

and I have no idea what (if anything) has changed or improved in the meantime.

@iabyn I don't think anything changed/improved on this side, my proposed change is really about the form and making the paragraph shorter, reordered (with most common case first) and more "accessible"

@thibaultduponchelle thibaultduponchelle force-pushed the rmg_improve_corelist_section branch from 2569225 to b2d718a Compare September 25, 2025 14:43
@thibaultduponchelle
Copy link
Member Author

I updated again and I think I got it right.

The section keeps the useful bits related to MAINT from the old section, better links to the email, reorders to make most common case to appear first, and makes some very little changes on the wording.

@thibaultduponchelle thibaultduponchelle force-pushed the rmg_improve_corelist_section branch from b2d718a to 74a2815 Compare September 25, 2025 14:55
@thibaultduponchelle thibaultduponchelle force-pushed the rmg_improve_corelist_section branch from 74a2815 to 10daac8 Compare September 25, 2025 15:14
@khwilliamson khwilliamson merged commit fb4d3f5 into Perl:blead Sep 26, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants