Skip to content

Rename _isQUOTEMETA to isQUOTEMETA_ #23555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
+10 −6
Merged

Rename _isQUOTEMETA to isQUOTEMETA_ #23555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/XS-APItest/APItest.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6723,7 +6723,7 @@ test_UTF8_IS_REPLACEMENT(char *s, STRLEN len)
bool
test_isQUOTEMETA(UV ord)
CODE:
RETVAL = _isQUOTEMETA(ord);
RETVAL = isQUOTEMETA(ord);
OUTPUT:
RETVAL

Expand Down
8 changes: 6 additions & 2 deletions handy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1691,7 +1691,9 @@ END_EXTERN_C
( (! cBOOL(FITS_IN_8_BITS(c))) \
|| (PL_charclass[(U8) (c)] & CC_mask_(CC_NONLATIN1_FOLD_)))

# define _isQUOTEMETA(c) generic_isCC_(c, CC_QUOTEMETA_)
# if defined(PERL_CORE) || defined(PERL_IN_XS_APITEST)
# define isQUOTEMETA(c) generic_isCC_(c, CC_QUOTEMETA_)
# endif

/* is c a control character for which we have a mnemonic? */
# if defined(PERL_CORE) || defined(PERL_EXT)
Expand Down Expand Up @@ -1822,7 +1824,9 @@ END_EXTERN_C
/* The following are not fully accurate in the above-ASCII range. I (khw)
* don't think it's necessary to be so for the purposes where this gets
* compiled */
# define isQUOTEMETA_(c) (FITS_IN_8_BITS(c) && ! isWORDCHAR_L1(c))
# if defined(PERL_CORE) || defined(PERL_IN_XS_APITEST)
# define isQUOTEMETA(c) (FITS_IN_8_BITS(c) && ! isWORDCHAR_L1(c))
# endif

/* Many of the macros later in this file are defined in terms of these. By
* implementing them with a function, which converts the class number into
Expand Down
6 changes: 3 additions & 3 deletions pp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5073,7 +5073,7 @@ PP(pp_quotemeta)
bool to_quote = FALSE;

if (UTF8_IS_INVARIANT(*s)) {
if (_isQUOTEMETA(*s)) {
if (isQUOTEMETA(*s)) {
to_quote = TRUE;
}
}
Expand All @@ -5086,7 +5086,7 @@ PP(pp_quotemeta)
IN_LC_RUNTIME(LC_CTYPE)
||
#endif
_isQUOTEMETA(EIGHT_BIT_UTF8_TO_NATIVE(*s, *(s + 1))))
isQUOTEMETA(EIGHT_BIT_UTF8_TO_NATIVE(*s, *(s + 1))))
{
to_quote = TRUE;
}
Expand All @@ -5108,7 +5108,7 @@ PP(pp_quotemeta)
}
else if (IN_UNI_8_BIT) {
while (len--) {
if (_isQUOTEMETA(*s))
if (isQUOTEMETA(*s))
*d++ = '\\';
*d++ = *s++;
}
Expand Down
Loading