Process $self in method subs as a subsignature parameter
#23565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag indicates that `$self` argument handling has already been performed by the subroutine signature, so it should find the value already in the pad.
A "fence op" is a miscellaneous op fragment that performs some work for side-effects during processing of a subroutine signature. In terms of timing, it will run at some time after any previously-defined arguments have been assigned from argument values passed in by the caller, but before any defaulting expressions for parameters that come after it are run. We specifically make no guarantees about whether parameters defined after this op have had their values assigned, nor whether defaulting expressions of earlier parameters have already been invoked. This is intentional because upcoming changes will change the order of these. The intention here is that method subroutines will use a fence op for the `OP_METHSTART` behaviour, ensuring that subsequent defaulting expressions can see the values of field bindings established by processing the `$self` parameter.
This has at least three advantages: * Removes more special-case code from `class.c` and makes generated optrees more similar to others * Ensures that no other ops appear in the optree before signature handling (as the OP_METHSTART used to). This will be useful for upcoming faster-signatures changes * Corrects the previous "off-by-one" error in parameter counts as reported by the argument count check exception messages
leonerd
force-pushed
the
self-as-subsignature
branch
from
1325801 to
600a61c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has at least three advantages:
Removes more special-case code from
class.cand makes generated optrees more similar to othersEnsures that no other ops appear in the optree before signature handling (as the OP_METHSTART used to). This will be useful for upcoming faster-signatures changes
Corrects the previous "off-by-one" error in parameter counts as reported by the argument count check exception messages
Includes addition to perldelta