Add valid_utf8_to_uv() #23578
Merged
Add valid_utf8_to_uv() #23578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
force-pushed
the
valid_utf8_to_uv
branch
from
c04910c to
e100ca4
Compare
bulk88
reviewed
Aug 15, 2025
khwilliamson
force-pushed
the
valid_utf8_to_uv
branch
from
e100ca4 to
9052ed9
Compare
khwilliamson
force-pushed
the
valid_utf8_to_uv
branch
from
9052ed9 to
e3f0a12
Compare
0351a62 extended hiding private functions from callers into the gcc world. Some functions are allowed only in extensions; so can not be marked as hidden; this commit discourages their use however, by hiding their prototypes to all but the core and extensions. It turns out that four functions were being used in modules we ship with that were marked as extensions-only; so they had to be made globally accessible.
khwilliamson
force-pushed
the
valid_utf8_to_uv
branch
from
e3f0a12 to
c410174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is identical to valid_utf8_to_uvchr(). They are both internal functions designed for when you are certain that the utf8 string to be translated is well formed; generally you created it yourself earlier.
The only reason for this new synonym is to lessen the cognitive load on programmers who should be using the "_uv" suffix functions, and not the "_uvchr" suffix ones for these sorts of tasks. By having this synonym, one doesn't have to learn that there are two.