keywords.h: Restrict to core #23612
Closed
keywords.h: Restrict to core #23612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
And ... why not? |
These are case statement values used in switch() statements in several core .c files. These are internal details about how we currently implement things. Exposing them to the outside world risks being stuck in this implementation.
khwilliamson
force-pushed
the
restrict_keywords_to_core
branch
from
19dada7 to
e80521b
Compare
Contributor
|
A quick grep suggests at least one CPAN dist (warnings::unused) would be broken by this. |
Contributor
|
warnings::unused looks abandoned (but still tests ok) Devel::Hook, XS::Parse::Keyword, XS::Parse::Sublike also use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are case statement values used in switch() statements in several core .c files. These are internal details about how we currently implement things. Exposing them to the outside world risks being stuck in this implementation.