Skip to content

Conversation

@khwilliamson
Copy link
Contributor

@khwilliamson khwilliamson commented Aug 24, 2025

Most of the text for this change was contributed by @tonycoz

  • This set of changes does not require a perldelta entry.

@khwilliamson khwilliamson requested a review from Grinnz August 24, 2025 00:35
@bulk88
Copy link
Contributor

bulk88 commented Aug 25, 2025

Is the feature of running PP code without use warnings; being removed from the Perl 5 Lang? semi-joke

99.999% of cases of this message are bug.

%0.001 are a performance optimization (not anymore b/c someone forgot to put a {\n no warnings 'uninit'; ....`, and STDERR is very slow in milliseconds).

I would change the language of the sentence to say "this almost always is a bug".

Not the proposed language in the PR, which would concrete a law that says uninit warning is absolute "proof of bug [no other justification or tech reason supplied]". Auto casting to IV 0, and using value IOK 0 as input might have be original developers intent.

The uninit warning being drawn didn't create a bug where there was none before.

@Grinnz
Copy link
Contributor

Grinnz commented Aug 25, 2025

I think it is more indicating that it may be a mistake in the code, not in Perl. In other words, it may indicate a logic error or bug.

Most of the text for this change was contributed by Tony Cook
@khwilliamson
Copy link
Contributor Author

Updated to incorporate @tonycoz wording; modified by me

@khwilliamson khwilliamson changed the title perldiag: Slightly clarify diagnostic explanation perldiag: Clarify uninit diagnostic explanation Sep 1, 2025
@khwilliamson khwilliamson merged commit 7eab72f into Perl:blead Sep 4, 2025
33 checks passed
@khwilliamson khwilliamson deleted the perldiag-uninit branch September 4, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants