Skip to content

find_script: avoid potential integer overflow #23654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mauke merged 1 commit into from
Aug 28, 2025
Merged

find_script: avoid potential integer overflow #23654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3410,7 +3410,7 @@ Perl_find_script(pTHX_ const char *scriptname, bool dosearch,
char *xfailed = NULL;
char tmpbuf[MAXPATHLEN];
char *s;
I32 len = 0;
size_t len = 0;
int retval;
char *bufend;
#if defined(DOSISH) && !defined(OS2)
Expand Down Expand Up @@ -3550,13 +3550,26 @@ Perl_find_script(pTHX_ const char *scriptname, bool dosearch,
if (len < sizeof tmpbuf)
tmpbuf[len] = '\0';
# else
s = delimcpy_no_escape(tmpbuf, tmpbuf + sizeof tmpbuf, s, bufend,
':', &len);
{
I32 n;
s = delimcpy_no_escape(tmpbuf, tmpbuf + sizeof tmpbuf, s,
bufend, ':', &n);
assert(n >= 0);
len = n;
}
# endif
if (s < bufend)
s++;
if (len + 1 + strlen(scriptname) + MAX_EXT_LEN >= sizeof tmpbuf)
continue; /* don't search dir with too-long name */
{
const size_t
available_len = sizeof tmpbuf - MAX_EXT_LEN - 1,
scriptname_len = strlen(scriptname);
if (
scriptname_len >= available_len ||
len >= available_len - scriptname_len
)
continue; /* don't search dir with too-long name */
}
if (len
# ifdef DOSISH
&& tmpbuf[len - 1] != '/'
Expand Down
Loading