Skip to content

pp_aasign: silence "var set but not used" warning #23689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iabyn merged 1 commit into from
Sep 7, 2025
Merged

pp_aasign: silence "var set but not used" warning #23689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions pp_hot.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3144,7 +3144,9 @@ PP(pp_aassign)
case SVt_PVHV: { /* normal hash */

SV **svp;
#ifndef PERL_RC_STACK
SSize_t i;
#endif
Copy link
Contributor

@jkeenan jkeenan Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When struggling with the build-time warning (as mentioned in #23661 (comment)), I got this far ...

SSize_t nelems = lastrelem - relem + 1;
HV *hash = MUTABLE_HV(lsv);

Expand Down Expand Up @@ -3323,7 +3325,12 @@ PP(pp_aassign)
SV **svp;
SV **topelem = relem;

for (i = 0, svp = relem; svp <= lastrelem; i++, svp++) {
#ifdef PERL_RC_STACK
for (svp = relem; svp <= lastrelem; svp++)
#else
for (i = 0, svp = relem; svp <= lastrelem; i++, svp++)
#endif
{
Copy link
Contributor

@jkeenan jkeenan Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but didn't realize I should have put this for loop statement inside an #ifdef ... #else ... #endif structure; below as well. Thanks.

SV *key = *svp++;
SV *val = *svp;
/* remove duplicates from list we return */
Expand Down Expand Up @@ -3368,7 +3375,12 @@ PP(pp_aassign)
}
else {
SV **svp;
for (i = 0, svp = relem; svp <= lastrelem; i++, svp++) {
#ifdef PERL_RC_STACK
for (svp = relem; svp <= lastrelem; svp++)
#else
for (i = 0, svp = relem; svp <= lastrelem; i++, svp++)
#endif
{
SV *key = *svp++;
SV *val = *svp;
#ifdef PERL_RC_STACK
Expand Down
Loading