Add COP warnings API #23731
Merged
Add COP warnings API #23731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
force-pushed
the
cop_warnings_API
branch
2 times, most recently
from
6e47d90 to
ec5fbb0
Compare
tonycoz
reviewed
Sep 22, 2025
tonycoz
reviewed
Sep 22, 2025
leonerd
force-pushed
the
cop_warnings_API
branch
5 times, most recently
from
656e0bf to
6e197fd
Compare
tonycoz
reviewed
Sep 22, 2025
tonycoz
approved these changes
Sep 22, 2025
leonerd
force-pushed
the
cop_warnings_API
branch
from
6e197fd to
4d16c66
Compare
This adds three new API functions: a pair to modify a COP by enabling or disabling a single warning bit within it, and a query function to ask if a given warning is already enabled. This API is provided for CPAN modules to use to modify the set of warnings present in a COP during compile-time. Currently modules need to use the `new_warnings_bitfield()` function, which was recently hidden by 09a0707. That change broke the `Syntax::Keyword::Try` module, as reported in Perl#23609.
leonerd
force-pushed
the
cop_warnings_API
branch
from
4d16c66 to
292aadd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three new API functions: a pair to modify a COP by enabling or disabling a single warning bit within it, and a query function to ask if a given warning is already enabled.
This API is provided for CPAN modules to use to modify the set of warnings present in a COP during compile-time. Currently modules need to use the
new_warnings_bitfield()function, which was recently hidden by 09a0707. That change broke theSyntax::Keyword::Trymodule, as reported in BBC ticket #23609. This change won't directly fix the BBC issue, but it will provide a new API that the module can use instead of calling the now-hidden function, so upstream will be fixed, and protected from future changes.--
Does not current include a perldelta, but I could be convinced to add one, for this relatively obscure new API.