utf8_to_uv_msgs: Make warning message consistent #23734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
reviewed
Sep 19, 2025
Contributor
leonerd
left a comment
leonerd
left a comment
There was a problem hiding this comment.
You say it's asserted, but then you deleted the assert(0) call.
khwilliamson
force-pushed
the
utf8_colon_warn
branch
from
bc92363 to
7b4de2b
Compare
This inserts a colon in the message to make it consistent with all the other similar ones. This will enable easier parsing of messages for future commits. If this change causes failures in any code in the field, that would be a Good Thing, as that code is now illegal. This message happens only when this function is called with a zero length string, which has been illegal for some releases. Doing this in a DEBUGGING build results in an assert(0). This message now only exists as a fallback to prevent bad or undefined behavior, should we get called with that anyway.
khwilliamson
force-pushed
the
utf8_colon_warn
branch
from
7b4de2b to
b4c1c7d
Compare
Contributor
Author
|
I thought the assert was redundant with an earlier one. But that apparently had already been removed. And I should have mentioned this line being removed in the commit message. The bottom line is, it's back in. |
tonycoz
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inserts a colon in the message to make it consistent with all the other similar ones.
It is safe to do this, as this code is executed only as a fallback under non-debugging builds. The condition that gets to this warning is asserted against in debugging builds.