PerlIO::via: remove redundant NULL check #23744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `if (gv)` check is pointless because `GvIOp(gv)` already dereferences `gv`, so if `gv` could be NULL, we'd already have undefined behavior (most likely a segfault) before reaching the `if`. Make the code's implicit assumptions explicit by adding `assert(gv)` before dereferencing. Fixes Coverity CID 584859.
khwilliamson
approved these changes
Sep 21, 2025
Contributor
khwilliamson
left a comment
khwilliamson
left a comment
There was a problem hiding this comment.
I thought we had already changed leading tabs into blanks in core files. That should be done here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
if (gv)check is pointless becauseGvIOp(gv)already dereferencesgv, so ifgvcould be NULL, we'd already have undefined behavior (most likely a segfault) before reaching theif.Make the code's implicit assumptions explicit by adding
assert(gv)before dereferencing.Fixes Coverity CID 584859.