Modernise SelectSaver #23754
Merged
Modernise SelectSaver #23754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use v5.40 and a modern testing framework. - Test different arguments to new. - Avoid writing to disk, it isn't necessary.
- Move the version declaration into the package line. - Move the code above the POD and add an __END__ token. - Use v5.40 to get strict, warnings, and the module_true feature. - Use subroutine signatures and remove hand rolled arity croak.
tonycoz
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split this PR into two commits, the first modernises the test, the second the actual code, this way we can prove the test passes with both the existing and modernised library. See each commit for details of what changed.
This is the first test under lib to use Test2::V0 but it's my understanding that should be fine as we're not testing the language itself, just a library. Some tests under lib already use Test::More so this doesn't seem like much of a step up, and definitely beats the hand-printed TAP it had before.