utf8.c: convert assertion from English to C #23755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity (CID 584855) complains that _invlist_search can return negative values. There is a comment that asserts this cannot happen here. Convert that comment to a C-level assert(). I don't know if that will silence Coverity, but it can't hurt to verify the invariant at least in debugging builds. (Also, convert RT ticket ID to Github issue number and do the PERL_ARGS_ASSERT_... thing first.)
khwilliamson
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity (CID 584855) complains that _invlist_search can return negative values. There is a comment that asserts this cannot happen here. Convert that comment to a C-level assert(). I don't know if that will silence Coverity, but it can't hurt to verify the invariant at least in debugging builds.
(Also, convert RT ticket ID to Github issue number and do the PERL_ARGS_ASSERT_... thing first.)