Skip to content

toke.c: Tidy up, mostly white space #23763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 25, 2025
Merged

toke.c: Tidy up, mostly white space #23763

merged 4 commits into from
Sep 25, 2025

Conversation

@khwilliamson
Copy link
Contributor

@khwilliamson khwilliamson commented Sep 24, 2025 •
edited
Loading

  • And a bit of code was also moved to avoid doing a calculation that would get thrown away.
  • An ARGS_ASSERT was moved to the beginning of the function, showing an error in the embed.fnc entry
  • This set of changes does not require a perldelta entry.

@tonycoz
Copy link
Contributor

tonycoz commented Sep 25, 2025 

The ARGS_ASSERT was later because of C89 that we no longer restricted
by.  Moving it showed a minor flaw.  The parameter name asserted for
didn't exist.

"because of C89 that we no longer restricted by"

which seems like it's missing a word.

The full stop after minor flaw could probably be a colon.

@tonycoz
Copy link
Contributor

tonycoz commented Sep 25, 2025

Looks ok otherwise.

@khwilliamson
toke.c: Remove C89 braces, and outdent
1470230 
These braces are not needed starting in C99, and we can outdent a large
block of code by removing them.
@khwilliamson
toke.c: Remove C89 braces, and outdent
2d94365 
Like the previous commit, these braces are not needed starting in C99,
and we can outdent a block of code by removing them.
@khwilliamson
S_intuit_method: Move code to earlier
e9ec819 
The ARGS_ASSERT was later down in the code because of C89 that we are no
longer restricted by.  Moving it showed a minor flaw: the parameter name
asserted for didn't exist.

The other code being later could throw away calculations we'd made.
Move it to before those calculations
@khwilliamson
toke.c: Remove trailing blank
aeea77d
@khwilliamson khwilliamson merged commit 3858926 into Perl:blead Sep 25, 2025
2 checks passed
@khwilliamson khwilliamson deleted the toke_white branch September 25, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khwilliamson @tonycoz